Add safe_block_hash to notify_forkchoice_updated #2851
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify CL client behaviour around
safe_block_hash
parameter of engine_forkchoiceUpdatedV1 function call. The PR proposes the following changes:safe_block_hash
parameter ofnotify_forkhoice_updated
function callsafe_block_hash
with thehead_block_hash
value until safe block function is implementedAlternatively,
safe_block_hash
may be stubbed with0x00..00
as introducing "safe" block tag to JSON-RPC API isn't expected within the Merge at least now, thus,safe_block_hash
value doesn't matter much. Though,head_block_hash
value is slightly preferred because i) most CL clients already implemented this behaviour ii) it's future compatible with the decision to deliver "safe" tag within the Merge but make it an alias to the head