Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump milagro bls binding version #2893

Merged
merged 1 commit into from
May 14, 2022

Conversation

ChihChengLiang
Copy link
Contributor

The new version of milagro bls binding supports py3.10(#2780) and arm (#2886).

Copy link
Member

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ralexstokes ralexstokes merged commit 30a3326 into ethereum:dev May 14, 2022
@ralexstokes
Copy link
Member

@ChihChengLiang do you have any thoughts on ensuring there aren't any regressions across different versions of this software?

@ChihChengLiang
Copy link
Contributor Author

@ralexstokes I think the regression is unlikely due to these reasons:

  1. The binding itself is covered in the same set of tests, which haven't changed during this upgrade.
  2. No significant updates in the upstream of the binding affect the codebase of binding and the spec.
  3. All spec tests that consume the binding passed.

@ralexstokes
Copy link
Member

the concern would be consistency across versions of the software but I agree it is unlikely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants