Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up README.md specs list #2903

Merged
merged 3 commits into from
Jun 6, 2022
Merged

Tidy up README.md specs list #2903

merged 3 commits into from
Jun 6, 2022

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented May 31, 2022 •
edited
Loading

  • To organize the forks and patches better, I tried to use tables to list the specs in README.
  • Add Capella and EIP4844 to README.md
  • Preview:

image

Personally, I think it looks better than before. Although HTML tags are annoying, we rarely need to update this file.

@hwwhww hwwhww requested a review from djrtwo May 31, 2022 18:56
ralexstokes
ralexstokes approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure we need the level of detail for fork version and previous fork but generally like the updated presentation!

@dapplion
Copy link
Collaborator

dapplion commented Jun 2, 2022 •
edited
Loading

not sure we need the level of detail for fork version and previous fork but generally like the updated presentation!

I would drop the fork version + previous fork to give more width to the other columns

@hwwhww
Copy link
Contributor Author

hwwhww commented Jun 2, 2022 •
edited
Loading

@ralexstokes @dapplion thanks for your feedback! I pruned the columns:
image

@djrtwo
Copy link
Contributor

djrtwo commented Jun 3, 2022

Awesome! One thing we might consider is adding if it's on mainnet (and maybe a fork epoch)?

I think it's mainly just nice to distinguish Bellatrix from Phase 0 and Altair in some way

@hwwhww
Copy link
Contributor Author

hwwhww commented Jun 6, 2022

@djrtwo 👍
Updated:
image

@djrtwo djrtwo merged commit 1113aa6 into dev Jun 6, 2022
@djrtwo djrtwo deleted the readme-table branch June 6, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralexstokes ralexstokes ralexstokes approved these changes

@djrtwo djrtwo djrtwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hwwhww @dapplion @djrtwo @ralexstokes