Allow LightClientUpdate with genesis finality
#2924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `state.finalized_checkpoint` references the genesis slot, it points to an empty `root`, instead of the actual genesis block hash. This patch updates the `LightClientUpdate` logic to allow including finality proofs for genesis `finalized_checkpoint.root`, better supporting non-mainnet. When including such a finality proof, the proof is for the empty `root`, but `finalized_header` is kept zeroed out to signify this edge case.
hwwhww
approved these changes
Jun 27, 2022
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
state.finalized_checkpointreferences the genesis slot, it pointsto an empty
root, instead of the actual genesis block hash. This patchupdates the
LightClientUpdatelogic to allow including finality proofsfor genesis
finalized_checkpoint.root, better supporting non-mainnet.When including such a finality proof, the proof is for the empty
root,but
finalized_headeris kept zeroed out to signify this edge case.