Cleanup light client tests #2929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Various cleanups and minor fixes: - Consistent terminology: - `signed_block` -> `attested_block` - `finalized_block_header` -> `finalized_header` - `snapshot_period` -> `store_period` - Use correct block in finality test (`blocks[-1]` instead of new one) - Add `signed_block_header` func to get header from `SignedBeaconBlock` - Remove `block_header` from `get_sync_aggregate` helper arguments - Use `state_transition_with_full_block` as shortcut for multiple calls - Have `finalized_header` actually be header instead of full block body - Consistent ordering of `assert` to match structure definition
hwwhww
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various cleanups and minor fixes:
signed_block->attested_blockfinalized_block_header->finalized_headersnapshot_period->store_periodblocks[-1]instead of new one)signed_block_headerfunc to get header fromSignedBeaconBlockblock_headerfromget_sync_aggregatehelper argumentsstate_transition_with_full_blockas shortcut for multiple callsfinalized_headeractually be header instead of full block bodyassertto match structure definition