Executable EIP-4844 specs (PR #2901 squashed and rebased) #2937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move more code into polynomial-commitments.md - Implement aggregated sidecar verification logic from PR ethereum#2915 - Rename `kzgs` to `kzg_commitments` Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
- Move constants around - Implement missing functions to make the spec executable Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
- Implement all the required glue code to make things executable - Implement a dummy KZG trusted setup Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
djrtwo
approved these changes
Jul 15, 2022
specs/eip4844/beacon-chain.md
Outdated
| all_versioned_hashes = [] | ||
| for tx in transactions: | ||
| if tx[0] == BLOB_TX_TYPE: | ||
| all_versioned_hashes.extend(tx_peek_blob_versioned_hashes(tx)) |
There was a problem hiding this comment.
extend is a bit python. I had to look it up! so most non-pythonista readers of speak might need to
specs/eip4844/p2p-interface.md
Outdated
| @@ -117,12 +106,14 @@ Alias `sidecar = signed_blobs_sidecar.message`. | |||
| - _[REJECT]_ the `sidecar.blobs` are all well formatted, i.e. the `BLSFieldElement` in valid range (`x < BLS_MODULUS`). | |||
| - _[REJECT]_ The KZG proof is a correctly encoded compressed BLS G1 Point -- i.e. `bls.KeyValidate(blobs_sidecar.kzg_aggregated_proof) | |||
| - _[REJECT]_ the beacon proposer signature, `signed_blobs_sidecar.signature`, is valid -- i.e. | |||
| ```python | |||
|
|
|||
| ``` | |||
There was a problem hiding this comment.
Suggested change
| ``` | |
| ```python |
There was a problem hiding this comment.
It is a silly workaround for not including this code snippet to pyspec. 😅
Alternatively, we can use "```py". Still not perfect though.
There was a problem hiding this comment.
I changed this code snippet into listed multi-steps: ec980da
|
|
||
| After retrieving the execution payload from the execution engine as specified in Bellatrix, | ||
| the blobs are retrieved and processed: | ||
|
|
||
| ```python | ||
| ``` |
There was a problem hiding this comment.
Is this code snippet expected to be run by the validator?
I would make "are retrieved and processed" more as a direction rather than just a passive statement that it happens. "execute the following" or something
| return [VersionedHash(opaque_tx[x:x+32]) for x in range(blob_versioned_hashes_offset, len(opaque_tx), 32)] | ||
| blob_versioned_hashes_offset = ( | ||
| message_offset | ||
| + uint32.decode_bytes(opaque_tx[(message_offset + 156):(message_offset + 160)]) |
There was a problem hiding this comment.
Was this math previously incorrect? (that it previously didn't add in message_offset)
hwwhww
force-pushed
the
eip4844-exe-squashed-and-rebased
branch
from
90edfb9 to
8776c05
Compare
…ig_fork_epoch_overrides` `config_fork_epoch_overrides`: since Capella and EIP4844 are in parallel, need to check if the field exists Update `compute_fork_version`
hwwhww
force-pushed
the
eip4844-exe-squashed-and-rebased
branch
from
8776c05 to
ec980da
Compare
|
Updated
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a squashed and rebased version of PR #2901 which makes EIP-4844 executable.
Squashing was non-trivial because of the various
Merge branch 'dev' into eip4844-execommits that were included in #2901, but I think this is a correct attempt.@hwwhww I would appreciate a review here. The
git diffbetween this branch and the branch from PR #2901 should be all the changes indevthat happened inbetween and were orthogonal to #2901.