Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validator_index to Withdrawal #3050

Merged
merged 3 commits into from
Oct 20, 2022
Merged

Add validator_index to Withdrawal #3050

merged 3 commits into from
Oct 20, 2022

Conversation

mcdee
Copy link
Contributor

@mcdee mcdee commented Oct 18, 2022

As per #3020

@dapplion
Copy link
Collaborator

Would be good to check in with explorers and other data consumers to understand the real value of adding this property.

@hwwhww hwwhww added the Capella label Oct 19, 2022
hwwhww
hwwhww approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mcdee! I made a minor change in the test & fix the irrelevant lint error. LGTM!

@hwwhww hwwhww merged commit 46e4473 into ethereum:dev Oct 20, 2022
@hwwhww hwwhww mentioned this pull request Oct 20, 2022
Closed
@terencechain terencechain mentioned this pull request Oct 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwwhww hwwhww hwwhww approved these changes

Assignees
No one assigned
Labels
Capella
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcdee @dapplion @hwwhww