Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EIP4844 to testgen and add more Capella+EIP4844 random fork tests #3110

Merged
merged 8 commits into from
Nov 18, 2022
Merged

Add EIP4844 to testgen and add more Capella+EIP4844 random fork tests #3110

merged 8 commits into from
Nov 18, 2022

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Nov 17, 2022 •
edited
Loading

  • EIP-4844
    • To do math, convert SSZ objectroots_of_unity_brp to Python integers
  • Add Capella and EIP4844 fork random tests
    • tests/core/pyspec/eth2spec/test/capella/fork/test_capella_fork_random.py
    • tests/core/pyspec/eth2spec/test/eip4844/fork/test_eip4844_fork_random.py
  • Add EIP4844 to test vector generators

WIP

  • add random tests

@hwwhww hwwhww requested review from djrtwo and ralexstokes November 17, 2022 19:49
@hwwhww hwwhww mentioned this pull request Nov 17, 2022
Closed
5 tasks
djrtwo
djrtwo approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice

@hwwhww hwwhww merged commit 46c0447 into dev Nov 18, 2022
@hwwhww hwwhww deleted the eip4844-test-vectors branch November 18, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djrtwo djrtwo djrtwo approved these changes

@ralexstokes ralexstokes Awaiting requested review from ralexstokes

Assignees
No one assigned
Labels
scope:CI/tests/pyspec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hwwhww @djrtwo