proper EL block hash implementation in tests #3126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces the "FAKE RLP HASH" in `ExecutionPayload.block_hash` of all generated tests with the correct value.
|
Looks great! 👍 As a further refactor (and probably in a separate PR) it does make sense to implement |
hwwhww
approved these changes
Dec 13, 2022
Comment on lines
86
to
89
| if is_post_capella(spec): | ||
| # withdrawals_root | ||
| execution_payload_header_rlp.append((Binary(32, 32), withdrawals_trie_root)) | ||
|
|
There was a problem hiding this comment.
Need to add eip4844 excess_data_gas field.
if is_post_eip4844(spec):
# excess_data_gas
execution_payload_header_rlp.append((big_endian_int, payload_header.excess_data_gas))
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the "FAKE RLP HASH" in
ExecutionPayload.block_hashof all generated tests with the correct value.