Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update G2 trusted setup length to 65 #3156

Merged
merged 1 commit into from
Dec 14, 2022
Merged

Update G2 trusted setup length to 65 #3156

merged 1 commit into from
Dec 14, 2022

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Dec 13, 2022

Thank @pawanjay176 for raising this issue.

As @dankrad pointed out:

  • The full setup will have 65 so that it can provide multiproofs up to size 64 field elements (2kB)
  • It is okay to use 65 G2 elements for both mainnet and minimal presets.

This PR:

  • Add KZG_SETUP_G2_LENGTH := 65
  • Update the length of KZG_SETUP_G2 to Vector[G2Point, KZG_SETUP_G2_LENGTH]
  • Update testing trusted setups accordingly

nitpicking: it looks a little weird that there is no KZG_SETUP_G1_LENGTH := 4096... but it's simpler just to use FIELD_ELEMENTS_PER_BLOB.

@hwwhww hwwhww added the Deneb was called: eip-4844 label Dec 13, 2022
@djrtwo djrtwo merged commit f7187a6 into dev Dec 14, 2022
@djrtwo djrtwo deleted the kzg-trusted-setup branch December 14, 2022 15:15
@asn-d6
Copy link
Contributor

asn-d6 commented Dec 14, 2022

Danny beat me to it, but LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deneb was called: eip-4844
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants