Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some nits in eip4844 specs #3158

Merged
merged 2 commits into from
Dec 14, 2022
Merged

Fix some nits in eip4844 specs #3158

merged 2 commits into from
Dec 14, 2022

Conversation

jtraglia
Copy link
Member

This PR fixes some minor nits I noticed when reading these:

  • Replace "EIP4844" with "EIP-4844" where it makes sense.
    • It is written with a dash most of the time.
  • Wrap PayloadAttributes in backticks as it's a code symbol.
  • Remove period between sentence and em dash (--).
  • Put the i.e. part on a separate line for consistency.
  • Reformat a table so it's formatted properly.
  • Make "point" in "BLS G1 point" lowercase.

ralexstokes
ralexstokes approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jtraglia
Copy link
Member Author

Thanks. I'm not sure what's up with CircleCI though...

Either git or ssh (required by git to clone through SSH) is not installed in the image. Falling back to CircleCI's native git client but the behavior may be different from official git. If this is an issue, please use an image that has official git and ssh installed.

@ralexstokes ralexstokes reopened this Dec 13, 2022
@ralexstokes
Copy link
Member

I'm not sure what's up with CircleCI though...

yeah something seems broken..

hwwhww
hwwhww approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jtraglia! I kicked the weird CircleCI.

@hwwhww hwwhww merged commit a57e156 into ethereum:dev Dec 14, 2022
@hwwhww hwwhww added the general:proofread spelling, grammar, accuracy label Dec 14, 2022
@jtraglia jtraglia deleted the fix-eip4844-spec-nits branch December 14, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwwhww hwwhww hwwhww approved these changes

@ralexstokes ralexstokes ralexstokes approved these changes

Assignees
No one assigned
Labels
general:proofread spelling, grammar, accuracy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtraglia @ralexstokes @hwwhww