-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
specially mark EIP4844 changes #3406
Conversation
@@ -41,16 +41,15 @@ | |||
|
|||
## Introduction | |||
|
|||
This upgrade adds blobs to the beacon chain as part of Deneb. This is an extension of the Capella upgrade. | |||
|
|||
The blob transactions are packed into the execution payload by the EL/builder with their corresponding blobs being independently transmitted and are limited by `MAX_DATA_GAS_PER_BLOCK // DATA_GAS_PER_BLOB`. However the CL limit is independently defined by `MAX_BLOBS_PER_BLOCK`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved this note to next to MAX_BLOBS_PER_BLOCK
preset definition.
Deneb is a consensus-layer upgrade containing a number of features. Including: | ||
* [EIP-4844](https://eips.ethereum.org/EIPS/eip-4844): Shard Blob Transactions scale data-availability of Ethereum in a simple, forwards-compatible manner. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other features will join this list later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! seems like a reasonable approach imo
left a couple of nits
@@ -336,7 +336,7 @@ def evaluate_polynomial_in_evaluation_form(polynomial: Polynomial, | |||
|
|||
### KZG | |||
|
|||
KZG core functions. These are also defined in Deneb execution specs. | |||
KZG core functions. These are also defined in Deneb execution specs for EIP-4844. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The top of this doc mentions "required for Deneb specification". I might be explicit up there that it is for 4844 (within Deneb)
specs/deneb/validator.md
Outdated
@@ -98,6 +98,8 @@ All validator responsibilities remain unchanged other than those noted below. | |||
|
|||
##### Blob KZG commitments | |||
|
|||
[New in Deneb:EIP4844] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like we should add more annotations to this doc -- e.g. to "Constructing the SignedBlobSidecar
s" and the data structures added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if we need this but I can see how it could be helpful to someone trying to digest the new specs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with this. This looks good to me :)
We are planning to include additional features (#3182) in the Deneb fork. This PR modifies the previous "[New in Deneb]" comment to "[New in Deneb:EIP4844]", allowing us to differentiate the sources once we integrate these new features.
Usine the notation
EIP4844
rather thanEIP-4844
because it's the form we use for feature spec constant, and it's shorter.