EIP-6914: Update the equivocating indices in the fork-choice store #3446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we sometimes reuse the slashed validator index, we need to remove it from the list of equivocating indices in the fork-choice store.
djrtwo
approved these changes
Jul 14, 2023
|
|
||
| A new handler is added with this upgrade: | ||
|
|
||
| - `on_reused_index(store, index)` whenever a validator index `index: ValidatorIndex` is reused |
There was a problem hiding this comment.
This is a bit wordy, but I'd like to provide a more specific clarification of what this means.
Suggested change
| - `on_reused_index(store, index)` whenever a validator index `index: ValidatorIndex` is reused | |
| - `on_reused_index(store, index)` whenever a validator index `index: ValidatorIndex` is reused. That is [`get_index_for_new_validator()`](./beacon-chain.md#get_index_for_new_validator) provides an index due a return value of `True` from [`is_reusable_validator()`](./beacon-chain.md#is_reusable_validator). |
dapplion
approved these changes
Jul 20, 2023
badasserry
approved these changes
Jan 5, 2024
badasserry
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since, in EIP-6914, we sometimes reuse the slashed validator index, we need to remove it from the list of equivocating indices in the fork-choice store.
See #3335 (comment) for discussion. Thank @dapplion for the solution.