Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank @rolfyone for reporting it!
https://media.githubusercontent.com/media/ethereum/consensus-spec-tests/master/tests/mainnet/bellatrix/fork_choice/should_override_forkchoice_update/pyspec_tests/should_override_forkchoice_update__true/steps.yaml
There is a tick
1573
after tick1576
, which should be impossible.Another further bug-free fix is to add the precondition
assert time > store.time
inon_tick
function, given that we have stated "on_tick(store, time)
whenevertime > store.time
wheretime
is the current Unix time". I'll open another PR for it.