Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PeerDAS: Check for degree overflow in multiply_polynomialcoeff() #3619

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

asn-d6
Copy link
Contributor

@asn-d6 asn-d6 commented Mar 8, 2024

This PR addresses a potential PolynomialCoeff overflow that can occur if we attempt to multiply two high degree polynomials. While this is not triggerable in the current spec, it's a good idea to be defensive about this.

@asn-d6
Copy link
Contributor Author

asn-d6 commented Mar 12, 2024

Also pushed 4b6b07b to make the definition of PolynomialCoeff a bit cleaner. Let me know if you think it's off topic and I can push it on a new PR.

Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed one minor check (due to the hardcoded_custom_type_dep_constants usage).

LGTM!

Copy link
Member

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too 😄

@hwwhww hwwhww added the EIP-7594 PeerDAS label Mar 14, 2024
@hwwhww hwwhww merged commit 46b118a into ethereum:dev Mar 14, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EIP-7594 PeerDAS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants