chore: use py-arkworks's multi-exp method inside of g1_lincomb and g2_lincomb
#3714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevaundray
force-pushed
the
kw/use-optimized-bls-msm
branch
from
733a255 to
640675f
Compare
kevaundray
changed the title
|
Copying @hwwhww previous profiling information: |
|
Tentatively, after this PR, the bottleneck switches to divide_polynomial_coefff -- there is a separate PR open to optimize that if we need to.
|
|
Note that most of G1lincomb is spent deserializing -- we can likely also optimize this in the future with either an API change or just a batch deserialization method as the bottleneck in deserialisation is likely the sqrt |
|
Going to deduplicate the methods in bls.py |
kevaundray
changed the title
g1_lincomb and g2_lincomb
kevaundray
commented
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this PR is to reduce CI times. Switch from double-and-add to the bucket method.