Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make get_custody_columns return sorted values and add get_custody_columns tests #3715

Merged
merged 3 commits into from
Apr 24, 2024
Merged

Make get_custody_columns return sorted values and add get_custody_columns tests #3715

merged 3 commits into from
Apr 24, 2024

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Apr 23, 2024

This PR makes get_custody_columns return sorted values and adds basic get_custody_columns test vectors.

TODO:

  • enable EIP7594 testgen in this PR or another PR

@hwwhww hwwhww added the EIP-7594 PeerDAS label Apr 23, 2024
@hwwhww hwwhww mentioned this pull request Apr 23, 2024
Closed
4 tasks
@hwwhww hwwhww requested review from ralexstokes and jtraglia April 23, 2024 16:53
jtraglia
jtraglia reviewed Apr 23, 2024
View reviewed changes
Copy link
Member

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I have some minor suggestions.

tests/formats/networking/get_custody_columns.md Outdated Show resolved Hide resolved
tests/formats/networking/get_custody_columns.md Outdated Show resolved Hide resolved
tests/core/pyspec/eth2spec/test/eip7594/networking/test_get_custody_columns.py Outdated Show resolved Hide resolved
tests/core/pyspec/eth2spec/test/eip7594/networking/test_get_custody_columns.py Show resolved Hide resolved
tests/core/pyspec/eth2spec/test/eip7594/networking/test_get_custody_columns.py Outdated Show resolved Hide resolved
hwwhww and others added 2 commits April 24, 2024 18:40
@hwwhww @jtraglia
Apply suggestions from code review
b257400 
Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com>
@hwwhww
Apply suggestions from @jtraglia
24899b7
jtraglia
jtraglia approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 thanks for making those additions!

@hwwhww hwwhww merged commit e1d7121 into dev Apr 24, 2024
28 checks passed
@hwwhww hwwhww deleted the das-test-vectors branch April 24, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtraglia jtraglia jtraglia approved these changes

@ralexstokes ralexstokes Awaiting requested review from ralexstokes

Assignees
No one assigned
Labels
EIP-7594 PeerDAS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hwwhww @jtraglia