EIP-7594: add custody settings config #3766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwwhww
reviewed
May 15, 2024
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
AgeManning
reviewed
May 15, 2024
| @@ -158,6 +158,9 @@ NUMBER_OF_COLUMNS: 128 | |||
| MAX_CELLS_IN_EXTENDED_MATRIX: 768 | |||
| DATA_COLUMN_SIDECAR_SUBNET_COUNT: 32 | |||
| MAX_REQUEST_DATA_COLUMN_SIDECARS: 16384 | |||
| SAMPLES_PER_SLOT: 8 | |||
| CUSTODY_REQUIREMENT: 1 | |||
| TARGET_NUMBER_OF_PEERS: 70 | |||
There was a problem hiding this comment.
Do we need the target number of peers in the config?
Currently I think most clients expose this via a CLI flag. Each client sets their own defaults based on node-resources and misc tradeoffs with performance. I think we probably still want to leave this up to client implementations to set
dapplion
reviewed
May 15, 2024
There was a problem hiding this comment.
Re including this values in the spec:
SAMPLES_PER_SLOT: As of today sampling is only used for a node to influence its own view on what's safe. This is subjective and different users may have different safety requirements. I would exclude this value from the configCUSTODY_REQUIREMENT: Only makes sense to add to the spec if this is the minimum custody per NodeID, enforceable with peer scoring.TARGET_NUMBER_OF_PEERS: Clients allow to customize peer counts. Clients may choose to show warnings if the user selects a value less than this. Then I'm not sure of the usefulness of having this parameter in the spec. Unless we expect different networks to have widely different peers needs and it being convenient to standardized those warning messages
For the spec format, we just need to put them into either presets or configurations 😅 |
hwwhww
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.