Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename CellID to CellIndex #3797

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Conversation

jtraglia
Copy link
Member

This PR renames the CellID type to CellIndex and renames variables (like cell_id and cell_indices). I believe that we should reserve "ID" for unordered items, like node IDs. In practice, the cell ID was used as an index.

Copy link
Contributor

@asn-d6 asn-d6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@asn-d6 asn-d6 merged commit 7b7ada7 into ethereum:dev Jun 11, 2024
26 checks passed
@jtraglia jtraglia deleted the rename-cellid-to-cellindex branch June 11, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EIP-7594 PeerDAS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants