-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP-7594: Specify data column sidecar verification functions to run #3963
Conversation
For by root and by range requests checks, the exact function to run is specified for KZG commitments, but not for the inclusion proof. This PR aligns both checks.
Additional question: Should the Consequences could be quite dramatic if a client actually considers a block with data column sidecars with invalid inclusion proof and/or invalid KZG proofs as available. |
Precedent says no. For example, the equivalent check for consensus-specs/specs/deneb/p2p-interface.md Line 294 in 57483cb
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I like explicitly calling out those functions.
Could we mention verify_data_column_sidecar
too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. However, I agree with @jtraglia that we should mention verify_data_column_sidecar
too.
Thank you for the remark and change @jtraglia! |
For by root and by range requests checks, the exact function to run is specified for KZG commitments, but not for the inclusion proof.
This PR aligns both checks.