eip7251: Add missed exit checks to consolidation processing #4000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtraglia
approved these changes
Oct 31, 2024
|
A side note, the cause of this issue makes me think that we need one function that checks all exit conditions to be used in already three places: voluntary_exit, withdrawal_request and consolidation_request processing. This can be done in a separate PR |
|
lgtm :) |
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of checks that the protocol does when processing a voluntary exit was not included into consolidation request processing, this PR fixes that, those checks are:
assert current_epoch >= source_validator.activation_epoch + SHARD_COMMITTEE_PERIODassert get_pending_balance_to_withdraw(state, source_index) == 0Since the exit is the first step of consolidation process, it makes sense to preserve all invariants that we have for voluntary exit conditions. cc @fradamt