Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly parent_root check in state transition #647

Closed
wants to merge 1 commit into from

Conversation

JustinDrake
Copy link
Collaborator

No description provided.

@hwwhww
Copy link
Contributor

hwwhww commented Feb 18, 2019

  1. But hasn't it been checked in the "processing block conditions"?
    https://github.com/ethereum/eth2.0-specs/blob/dev/specs/core/0_beacon-chain.md#beacon-chain-processing
    • The parent block with root block.parent_root has been processed and accepted.
  2. For nodes (not only validators), it also implied that they'd switch the local view of BeaconState to the view of block parent_root (parent_block.state_root) before applying state transition.

@JustinDrake
Copy link
Collaborator Author

I see the sections "Beacon chain processing" and "Beacon chain state transition function" as serving two different functions.

The first section involves subjectivity (time, observed blocks, observed offchain attestations, ...) whereas the second is a purely objective state transition function. The parent_root check is an objective check part of the state transition function. It doesn't hurt to mention parent_root in the first section to help the presentation.

@JustinDrake
Copy link
Collaborator Author

Closing in favour of #649.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants