initialize disc v5.1 packet format #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pipermerriam
force-pushed
the
piper/update-to-latest-wire-protocol
branch
3 times, most recently
from
aef84c5 to
9caf876
Compare
pipermerriam
commented
Aug 5, 2020
ddht/v5_1/datagram.py
Outdated
|
|
||
| class OutgoingDatagram(NamedTuple): | ||
| datagram: bytes | ||
| receiver_endpoint: Endpoint |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
pipermerriam
commented
Aug 5, 2020
ddht/v5_1/datagram.py
Outdated
| class IncomingMessage(NamedTuple): | ||
| message: BaseMessage | ||
| sender_endpoint: Endpoint | ||
| sender_node_id: NodeID |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
pipermerriam
commented
Aug 5, 2020
ddht/v5_1/datagram.py
Outdated
| class OutgoingMessage(NamedTuple): | ||
| message: BaseMessage | ||
| receiver_endpoint: Endpoint | ||
| receiver_node_id: NodeID |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
pipermerriam
commented
Aug 5, 2020
ddht/v5_1/messages.py
Outdated
| topic_sedes = Binary.fixed_length(TOPIC_HASH_SIZE) | ||
|
|
||
|
|
||
| class IPAddressSedes(Binary): # type: ignore |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
pipermerriam
force-pushed
the
piper/update-to-latest-wire-protocol
branch
5 times, most recently
from
cef403b to
ebab34c
Compare
pipermerriam
force-pushed
the
piper/update-to-latest-wire-protocol
branch
from
ebab34c to
263dc76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The discovery v5 protocol specification is being updated with a new wire protocol:
ethereum/devp2p#157
How was it fixed?
Implemented the new protocol in
ddht.v5_1Preservation of the current
v5implementation has been kept in place since there is currently a live network of nodes (mostly from the beacon chain?) for which we may still want to be able to interact with.Currently this only implements the low level messaging and doesn't implement the overall application structure (like populating and managing a routing table).
Cute Animal Picture