Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove eip preamble entry #68

Merged
merged 19 commits into from
Mar 29, 2023
Merged

Remove eip preamble entry #68

merged 19 commits into from
Mar 29, 2023

Conversation

Pandapip1
Copy link
Member

Allows for automatic number assignment.

@Pandapip1 Pandapip1 changed the title Make eip preamble entry optional Update requirements on eip preamble entry Mar 22, 2023
@Pandapip1
Copy link
Member Author

Pandapip1 commented Mar 22, 2023

@SamWilsn here's your "Draft EIPs with a number should require manual merging"

@Pandapip1 Pandapip1 changed the title Update requirements on eip preamble entry Require eip-number-less drafts Mar 22, 2023
@Pandapip1 Pandapip1 changed the title Require eip-number-less drafts Remove eip preamble entry Mar 28, 2023
eipw-lint/src/lib.rs Outdated Show resolved Hide resolved
eipw-lint/src/lints/preamble.rs Outdated Show resolved Hide resolved
eipw-lint/src/lints/preamble.rs Outdated Show resolved Hide resolved
@Pandapip1
Copy link
Member Author

Pandapip1 commented Mar 28, 2023

@SamWilsn I repurposed the PR to get rid of the eip preamble entry altogether.

@Pandapip1
Copy link
Member Author

Pandapip1 commented Mar 29, 2023

@SamWilsn tests have been removed and/or fixed.

@SamWilsn SamWilsn merged commit 58316e6 into ethereum:master Mar 29, 2023
SamWilsn added a commit that referenced this pull request Apr 17, 2023
SamWilsn added a commit that referenced this pull request Apr 17, 2023
SamWilsn added a commit that referenced this pull request Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants