fix: mod reduce msg_hash as input of the HMAC function #102
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Eth-keys did not fully respect RFC6979 3.2.d.
The message digest should be modulo reduced before being passed as input of HMAC function.
This issue was found after this analysis.
According to the RFC, it should pass through a
bits2octets
function:By looking into the definition of
bits2octets
, it states that the message digest needs to be reduced:Closes #101
How was it fixed?
Todo: