Fix coincurve backend signature validation #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pipermerriam
approved these changes
Jun 7, 2019
|
|
||
|
|
||
| def coerce_low_s(value: int) -> int: | ||
| return min(value, -value % SECPK1_N) |
There was a problem hiding this comment.
I think this probably deserves a docstring.
| @@ -75,7 +78,8 @@ def ecdsa_verify(self, | |||
| msg_hash: bytes, | |||
| signature: BaseSignature, | |||
| public_key: PublicKey) -> bool: | |||
| der_encoded_signature = der.two_int_sequence_encoder(signature.r, signature.s) | |||
| low_s = coerce_low_s(signature.s) | |||
There was a problem hiding this comment.
This probably deserves a comment to indicate why it is necessary.
|
Going to wait until Monday to release this since I'm out of town over the weekend and we try to avoid cutting releases on Fridays in case anything un-expected happens. |
Merged
carver
approved these changes
Jun 10, 2019
|
I ran both the py-evm fixtures and the failing Trinity test with this PR and everything seems to pass. So I think we can merge and release (would do it myself, but I don't have permissions in this repo). |
|
@jannikluhn v0.2.4 released with this merge! |
pacrob
pushed a commit
to pacrob/eth-keys
that referenced
this pull request
Dec 20, 2023
Use updated CircleCI images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
ECDSA signatures can be represented with a low or a high s: https://bitcoin.stackexchange.com/questions/83408/in-ecdsa-why-is-r-%E2%88%92s-mod-n-complementary-to-r-s
High-s signatures are forbidden in Ethereum, but only since Homestead, so
eth-keysneeds to support both forms. However, Coincurve rejects high-s signatures during verification.This error was introduced with the non recoverable signatures (prior to this we just recovered the signer and compared, so we didn't use the Coincurve signature verification function).
How was it fixed?
Convert an incoming high-s signature to its equivalent low-s representation before passing it to coincurve. Also, add some tests for this.
Cute Animal Picture