Cleanup address utils #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carver
approved these changes
Oct 15, 2018
Split generate_contract_address logic into multiple lines
onyb
force-pushed
the
cleanup-address-utils
branch
from
06528f9
to
225fe48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
eth_tester.utils.account.generate_contract_addressandeth_tester.utils.address.generate_contract_addresswere duplicates.eth_tester.utils.account.private_key_to_addresswas not using the standardeth_keysAPI.Closes #86.
How was it fixed?
eth_tester.utils.account.generate_contract_address.eth_tester.utils.address.generate_contract_addressto return a canonical address.eth_tester.utils.account.private_key_to_addressto useeth_keysAPI instead of the utils in thesekp256k1module.sekp256k1andjacobianmodules, which were not used anymore.Cute Animal Picture