Add exception message to from #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacqueswww
force-pushed
the
add_exception_message_to_from
branch
from
dd7f3d7
to
e89fb45
Compare
pipermerriam
approved these changes
Dec 10, 2018
eth_tester/backends/pyevm/main.py
Outdated
| @@ -471,6 +472,8 @@ def _get_normalized_and_unsigned_evm_transaction(self, transaction, block_number | |||
| return evm_transaction | |||
|
|
|||
| def _get_normalized_and_signed_evm_transaction(self, transaction, block_number='latest'): | |||
| if transaction['from'] not in self._key_lookup: | |||
| raise ValidationError('"from" key not available, does this account exist?') | |||
There was a problem hiding this comment.
This message seems like it could be improved a bit.
No
"from"key was provided in the transaction which is required for transaction signing
A bit more concise and hints at how the user can fix it.
There was a problem hiding this comment.
I am changing this message to No valid "from" key was provided... the reason is that one can specify a public key, but the the key isn't available to use (this is how I found the error, I specified a public key of a contract) ?
There was a problem hiding this comment.
If we wanted to get really fancy, we could list the valid keys and show the actual key, but that shouldn't hold up this PR.
carver
approved these changes
Dec 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
When supplying an invalid from address, one would receive a KeyError.
How was it fixed?
Throws a more useful exception.
Cute Animal Picture