Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade upstream dependency requirements #232

Merged
merged 2 commits into from
Jan 26, 2022

Conversation

kclowes
Copy link
Contributor

@kclowes kclowes commented Jan 21, 2022

What was wrong?

See ethereum/py-evm#2050. I did a premature upgrading of dependencies with breaking changes. Once we're ready to cut a new web3.py v6 branch, we can pull in the breaking upstream dependencies.

How was it fixed?

Pulled in the needed non-breaking changes, and left the breaking changes until we're ready to cut a new web3.py v6.

To-Do:

Cute Animal Picture

Cute animal picture

@kclowes kclowes changed the title [WIP] Test dependency revert Downgrade upstream dependency requirements Jan 26, 2022
@kclowes kclowes requested review from fselmo and pacrob January 26, 2022 18:20
Copy link
Contributor

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@kclowes kclowes merged commit 386b6ca into ethereum:master Jan 26, 2022
@kclowes kclowes deleted the revert-deps branch January 26, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants