Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement get_storage_at() #264

Merged
merged 4 commits into from
Jun 29, 2023
Merged

Implement get_storage_at() #264

merged 4 commits into from
Jun 29, 2023

Conversation

fselmo
Copy link
Contributor

@fselmo fselmo commented Jun 28, 2023

What was wrong?

closes #263

How was it fixed?

  • Implement get_storage_at() with validation and normalization for inbound storage_slot value and outbound storage value
  • Add tests
  • Tested against a local web3.py branch for compatibility, that PR will be coming after this is merged and released.

To-Do:

Cute Animal Picture

20230628_143605

@fselmo fselmo marked this pull request as ready for review June 28, 2023 20:37
@fselmo fselmo requested review from pacrob and reedsa June 28, 2023 20:37
@fselmo fselmo changed the title Get storage at Implement get_storage_at() Jun 28, 2023
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@fselmo fselmo merged commit 08c873a into ethereum:master Jun 29, 2023
@fselmo fselmo deleted the get-storage-at branch June 29, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement eth_getStorageAt
2 participants