PrivateMinerSample doesn't include transactions into blocks

[Nashatyrev]

No description provided.

[Nashatyrev]

The problem here is that we are not processing inbound transactions until sync is complete. For the miner node the sync is disabled. We had code which enabled tx processing if sync is off but it was accidentally commented by me while refactoring.
However this was not the best solution (to mine without sync process) if consider the following cases:

• the miner node starts alone and mines blocks from the best block it has, then some node connects which has the chain with higher difficulty. In this case miner should import all blocks and switch mining to the best one
• the miner node starts alone and mines blocks from the best block it has, then some node connects which has the chain with lower difficulty. In this case the sync is assumed to be done from the very beginning.
• the miner connects to a node, syncs with it and then starts mining

[Nashatyrev]

For now the following workaround should work for the miner node:

// ethereum - is the miner node instance
ethereum.addListener(new EthereumListenerAdapter() {
    @Override
    public void onHandShakePeer(Channel channel, HelloMessage helloMessage) {
        channel.onSyncDone(true);
    }
});

[Nashatyrev]

The regression is fixed (PrivateMinerSample should work fine), though this issue needs more advanced fix (see the first comment)

[Nashatyrev]

With Unsafe I've got approx. the same performance: 606cd46