Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Memory usage with empty size data in VM #1109

Merged
merged 1 commit into from
Jun 25, 2018
Merged

Conversation

zilm13
Copy link
Collaborator

@zilm13 zilm13 commented Jun 24, 2018

Should fix block 3467853 in Ropsten
Some points:

Over an account’s execution, the total fee for memoryusage
payable is proportional to smallest multiple of 32
bytes that are required such that all memory indices
(whether for read or write) are included in the range. This
is paid for on a just-in-time basis; as such, referencing an
area of memory at least 32 bytes greater than any previously
indexed memory will certainly result in an additional
memory usage fee.

From yellow paper. So, when addressing 0 length part of memory we are not addressing any memory part.

@zilm13 zilm13 requested a review from mkalinin June 24, 2018 18:18
@zilm13 zilm13 added the bug label Jun 24, 2018
@mkalinin mkalinin merged commit 25d0a00 into develop Jun 25, 2018
@zilm13 zilm13 deleted the fix/ropsten-3467853 branch June 26, 2018 17:45
@mkalinin mkalinin added this to the 1.9.0-Constantinople milestone Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants