Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instructions: consider definding undefined instruction's cost as 0 instead of -1 #356

Closed
gumb0 opened this issue Jul 16, 2019 · 0 comments · Fixed by #425
Closed

Instructions: consider definding undefined instruction's cost as 0 instead of -1 #356

gumb0 opened this issue Jul 16, 2019 · 0 comments · Fixed by #425

Comments

@gumb0
Copy link
Member

gumb0 commented Jul 16, 2019

evmc/lib/instructions/instruction_metrics.c

Line 9 in 22ed657

#define UNDEFINED -1

-1 might lead to some weird results in VM implementations, like block's gas cost going down when counted in pre-execution analysis, as seen in ethereum/evmone#93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

instructions: Set gas cost for undefined instructions to 0 ethereum/evmc
1 participant
@gumb0