Change values in instruction metrics #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
force-pushed
the
instruction_metrics
branch
3 times, most recently
from
98028d7 to
2162feb
Compare
gumb0
reviewed
Sep 27, 2019
include/evmc/instructions.h
Outdated
| @@ -188,11 +188,11 @@ struct evmc_instruction_metrics | |||
| /** The instruction gas cost. */ | |||
| int16_t gas_cost; | |||
|
|
|||
| /** The number of items the instruction pops from the EVM stack before execution. */ | |||
| int8_t num_stack_arguments; | |||
| /** The number of the EVM stack items required for the instruction. */ | |||
gumb0
reviewed
Sep 27, 2019
include/evmc/instructions.h
Outdated
|
|
||
| /** The number of items the instruction pushes to the EVM stack after execution. */ | ||
| int8_t num_stack_returned_items; | ||
| /** The EVM stack height change caused by the instruction execution. */ |
There was a problem hiding this comment.
I'd clarify that it's stack after execution - stack before
The values in the table are going to be changed in the following commit.
chfast
force-pushed
the
instruction_metrics
branch
from
2162feb to
2c3eb42
Compare
gumb0
approved these changes
Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates instruction metrics with changed values - they are easier to explain and represent number directly usable by VM implementations (will benefit aleth-interepreter).
This is tested against evmone's table: ethereum/evmone#191.
The modification can be easily verified by following the rule:
Continuation of #356.