SSTORE net gas metering support #127
Conversation
|
Please rebase. |
…of Constantinople
|
Rebased. |
| /** | ||
| * A storage item has been modified after being modified before: X -> Y -> Z. | ||
| */ | ||
| EVMC_STORAGE_MODIFIED_DIRTY = 4 |
There was a problem hiding this comment.
Why not place this next to MODIFIED? And why not just name it MODIFIED_AGAIN ?
There was a problem hiding this comment.
-
The
EVMC_STORAGE_MODIFIED_AGAINis better name indeed, we could change it. I just wanted if the EIP mentions this case as dirty. We could go even as far as proposing a change to the EIP. -
In some sense it is closer to
EVMC_STORAGE_MODIFIEDbut also describes a case that was historically added later. I was thinking about this but both options are fine for me.
There was a problem hiding this comment.
The EVMC_STORAGE_MODIFIED_AGAIN is better name indeed, we could change it.
How about changing it before ABI6 is released?
In some sense it is closer to EVMC_STORAGE_MODIFIED but also describes a case that was historically added later.
I think since this is added a breaking change I'd add it next to it, with the values pushed down.
If this enum would have been around for months I may be on a different opinion, but not in this case.
There was a problem hiding this comment.
Created an issue to track this: #129
|
Also this missed adding the definition to the Go binding. |
The single "modified dirty" status is enough to implement EIP-1283, see ethereum/aleth#5238
Closes #91