Simplify terminator instruction check

ethereum · Sep 10, 2019 · 91cea7d · 91cea7d
1 parent 5aa8b42
commit 91cea7d
Showing 1 changed file with 1 addition and 6 deletions.
diff --git a/lib/evmone/analysis.cpp b/lib/evmone/analysis.cpp
@@ -92,16 +92,11 @@ code_analysis analyze(
         else
             analysis.instrs.emplace_back(fns[opcode]);
 
-        bool create_new_block = false;
         switch (metrics.group)
         {
         default:
             break;
 
-        case terminator:
-            create_new_block = true;
-            break;
-
         case small_push:
         {
             const auto push_size = size_t(opcode - OP_PUSH1 + 1);
@@ -157,7 +152,7 @@ code_analysis analyze(
             break;
         }
 
-        if (create_new_block || (code_pos != code_end && *code_pos == OP_JUMPDEST))
+        if (metrics.group == terminator || (code_pos != code_end && *code_pos == OP_JUMPDEST))
         {
             // Save current block.
             const auto stack_req = block.stack_req <= std::numeric_limits<int16_t>::max() ?