Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ExecutionState::reset() #1004

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Conversation

chfast
Copy link
Member

@chfast chfast commented Sep 12, 2024

Reset previously omitted fields related to EOF execution: deploy_container and call_stack.

Reset previously omitted fields related to EOF execution:
`deploy_container` and `call_stack`.
@chfast chfast requested review from gumb0 and pdobacz September 12, 2024 13:05
@chfast chfast added the EOF label Sep 12, 2024
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.89%. Comparing base (00af48c) to head (88129ee).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1004   +/-   ##
=======================================
  Coverage   93.89%   93.89%           
=======================================
  Files         146      146           
  Lines       15485    15487    +2     
=======================================
+ Hits        14539    14541    +2     
  Misses        946      946           
Flag Coverage Δ
eof_execution_spec_tests 17.49% <0.00%> (-0.01%) ⬇️
ethereum_tests 27.76% <0.00%> (-0.01%) ⬇️
ethereum_tests_silkpre 19.45% <0.00%> (-0.01%) ⬇️
execution_spec_tests 19.02% <0.00%> (-0.01%) ⬇️
unittests 88.98% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
lib/evmone/execution_state.hpp 94.82% <100.00%> (+0.18%) ⬆️

Copy link
Collaborator

@pdobacz pdobacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe rearrange the reset statements to reflect order of declarations (also move call_stack up?).

@chfast
Copy link
Member Author

chfast commented Sep 12, 2024

maybe rearrange the reset statements to reflect order of declarations (also move call_stack up?).

oh, I thought they are in order. I'll check.

@chfast
Copy link
Member Author

chfast commented Sep 12, 2024

The reset handles the fields in the order the fields are declared in the class. This is as if it is some kind of constructor.
BTW, I wonder if this is some kind of design pattern.

@chfast chfast merged commit 7a46e72 into master Sep 12, 2024
25 checks passed
@chfast chfast deleted the baseline/fix_execution_state_reset branch September 12, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants