Fix max stack growth overflow #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #219 +/- ##
========================================
+ Coverage 99.88% 100% +0.11%
========================================
Files 5 5
Lines 848 849 +1
Branches 113 113
========================================
+ Hits 847 849 +2
+ Misses 1 0 -1 |
chfast
force-pushed
the
fix_max_stack_growth_overflow
branch
from
fd3ef03 to
27601a9
Compare
gumb0
approved these changes
Dec 3, 2019
|
What was happening before the change? Overflowed and never returned "stack_overflow" ? |
The stack overflow is not detected, but program crashes after accessing an out-of-bound stack item. |
axic
approved these changes
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.