ci: Drop -DNATIVE=ON for Windows builds #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Worthy a changelog entry? (e.g. slowdown on windows) |
NATIVE=ON for MSVC enables AVX instruction set. This make Windows release binaries unusable on CPUs not having AVX.
chfast
force-pushed
the
ci_windows_no_avx
branch
from
57dde2a to
629845f
Compare
Codecov Report
@@ Coverage Diff @@
## master #230 +/- ##
==========================================
- Coverage 100% 99.88% -0.12%
==========================================
Files 5 5
Lines 850 850
Branches 113 113
==========================================
- Hits 850 849 -1
- Misses 0 1 +1 |
Added. |
|
Looks good to me if you are waiting for feedback. |
jwasinger
pushed a commit
to jwasinger/evmone
that referenced
this pull request
Apr 27, 2021
loader: Expose DLL load error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NATIVE=ON for MSVC enables AVX instruction set. This make Windows release binaries unusable on CPUs not having AVX.