Baseline interpreter #261
Merged
Baseline interpreter #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
force-pushed
the
baseline
branch
3 times, most recently
from
477ba74 to
3dc2b12
Compare
|
Please also test against the SemanticTests, that should be the largest group of tests that run against the EVM. |
This is similar. |
gumb0
reviewed
Oct 19, 2020
chfast
force-pushed
the
baseline
branch
3 times, most recently
from
8d7141b to
dfd1d96
Compare
|
Some final benchmarks with Clang 11. |
Codecov Report
@@ Coverage Diff @@
## master #261 +/- ##
==========================================
+ Coverage 99.67% 99.75% +0.07%
==========================================
Files 23 24 +1
Lines 3073 3634 +561
==========================================
+ Hits 3063 3625 +562
+ Misses 10 9 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gumb0
reviewed
Dec 18, 2020
gumb0
reviewed
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "baseline" is a new interpreter added to evmone. It has much simpler, "classic" design and performs minimal amount of code analysis (only required JUMPDEST analysis, the code is unmodified). EVM instructions implementations are shared with "advanced" VM where possible.
To use it pass
O=0option.The initial benchmarking results look promising (see below). All done with Clang-11 compiler. The GCC-10 has lower performance, but I believe this can be fixed.
Moreover, the first PoC has some additional changes and tweaks (e.g. custom instruction table) and is up to 5% faster than this version. The old version is still available in baseline-old branch.
Solidity test suite
For solidity test suite it performs a tinny bit better.
Internal benchmark suite