advanced: Prevent invalid memory subscript index #339
Conversation
What version? Do you have CI log? |
|
Do you have a unit test for this? |
lib/evmone/execution.cpp
Outdated
| return evmc::make_result( | ||
| state.status, gas_left, &state.memory[state.output_offset], state.output_size); | ||
| return evmc::make_result(state.status, gas_left, | ||
| state.output_size != 0 ? &state.memory[state.output_offset] : nullptr, state.output_size); |
There was a problem hiding this comment.
This can be fixed with state.memory.data() + state.output_offset because evmc::make_result() will not use the pointer if output_size is 0.
Codecov Report
@@ Coverage Diff @@
## master #339 +/- ##
=======================================
Coverage 99.78% 99.78%
=======================================
Files 29 29
Lines 4108 4108
=======================================
Hits 4099 4099
Misses 9 9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
It was triggered by running Silkworm's core_test in Debug on Windows. Unfortunately, it didn't show in our Windows CI because it only has Release. |
yperbasis
force-pushed
the
win_out_of_range
branch
from
ddbce46 to
8819740
Compare
|
I suppose something like |
chfast
changed the title
* Update evmone to prevent out of range access * Switch back to upstream evm1 as ethereum/evmone/pull/339 is merged
triggered in MSVC debug build (Visual Studio 2019 version 16.10)