Make Baseline default, select Advanced with "advanced" flag #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #500 +/- ##
==========================================
- Coverage 99.41% 99.41% -0.01%
==========================================
Files 53 53
Lines 5271 5260 -11
==========================================
- Hits 5240 5229 -11
Misses 31 31
Flags with carried forward coverage won't be shown. Click here to find out more.
|
hugo-dc
reviewed
Aug 26, 2022
| @@ -31,12 +36,6 @@ The codebase of _evmone_ is optimized to provide fast and efficient execution of | |||
| and applied once per block during execution. | |||
| 3. Performs extensive and expensive bytecode analysis before execution. | |||
There was a problem hiding this comment.
Specify we need the advanced flag in order to enable the Advanced interpreter (?)
There was a problem hiding this comment.
Yes, I forgot to add it in the second commit. Good now?
yperbasis
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.