Precompiles: gas analysis and execution via stub #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
requested review from
AndreaLanfranchi,
axic,
gumb0,
rakita and
yperbasis
chfast
force-pushed
the
state_precompiles_stub
branch
2 times, most recently
from
8a39517 to
2a5e48c
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #524 +/- ##
==========================================
- Coverage 98.08% 97.37% -0.71%
==========================================
Files 60 61 +1
Lines 5837 5825 -12
==========================================
- Hits 5725 5672 -53
- Misses 112 153 +41
Flags with carried forward coverage won't be shown. Click here to find out more.
|
axic
reviewed
Nov 7, 2022
axic
reviewed
Nov 7, 2022
axic
reviewed
Nov 7, 2022
rodiazet
reviewed
Nov 30, 2022
chfast
force-pushed
the
state_precompiles_stub
branch
from
022dc89 to
e38045f
Compare
chfast
commented
Dec 11, 2022
chfast
force-pushed
the
state_precompiles_stub
branch
from
242db76 to
3fce7ed
Compare
rodiazet
approved these changes
Dec 13, 2022
chfast
force-pushed
the
state_precompiles_stub
branch
from
3fce7ed to
0f43598
Compare
Merged
axic
reviewed
Jan 4, 2023
| sha256 = 0x02, | ||
| ripemd160 = 0x03, | ||
| identity = 0x04, | ||
| expmod = 0x05, |
There was a problem hiding this comment.
Why expmod and not modexp? Yellowpaper? I know clients disagree on the naming.
There was a problem hiding this comment.
IDK, maybe because addmod and mulmod.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.