Implement EIP-663: Unlimited SWAP and DUP instructions #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #529 +/- ##
==========================================
+ Coverage 98.03% 98.08% +0.05%
==========================================
Files 59 59
Lines 5687 5837 +150
==========================================
+ Hits 5575 5725 +150
Misses 112 112
Flags with carried forward coverage won't be shown. Click here to find out more.
|
rodiazet
force-pushed
the
eip-663
branch
5 times, most recently
from
a8861e5 to
996d37b
Compare
rodiazet
force-pushed
the
eip-663
branch
2 times, most recently
from
132aed6 to
c2c0237
Compare
axic
reviewed
Nov 30, 2022
axic
reviewed
Nov 30, 2022
axic
reviewed
Dec 5, 2022
lib/evmone/instructions.hpp
Outdated
| return nullptr; | ||
| } | ||
|
|
||
| stack.push(stack[n]); |
There was a problem hiding this comment.
I think this misses the < 1024 check. push does not seem enforce the 1024 limit.
There was a problem hiding this comment.
The stack overflow check is done automatically by the interpreter. This information is in the instruction traits.
gumb0
reviewed
Dec 6, 2022
gumb0
reviewed
Dec 6, 2022
gumb0
reviewed
Dec 6, 2022
gumb0
reviewed
Dec 6, 2022
gumb0
reviewed
Dec 6, 2022
test/unittests/evm_test.cpp
Outdated
| EXPECT_STATUS(EVMC_SUCCESS); | ||
| EXPECT_OUTPUT_INT(256); | ||
|
|
||
| execute(full_stack_code + OP_DUPN + "fe" + OP_DUPN + "ff"); |
There was a problem hiding this comment.
would it overflow with POP as in checks above?
Suggested change
| execute(full_stack_code + OP_DUPN + "fe" + OP_DUPN + "ff"); | |
| execute(full_stack_code + OP_POP + OP_DUPN + "fe" + OP_DUPN + "ff"); |
There was a problem hiding this comment.
Ah I see OP_POP was needed because of ret_top() in the end
gumb0
reviewed
Dec 6, 2022
gumb0
approved these changes
Dec 7, 2022
chfast
changed the title
chfast
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eips.ethereum.org/EIPS/eip-663