Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce eofparse and eofparsefuzz #568

Merged
merged 4 commits into from
Feb 17, 2023
Merged

Introduce eofparse and eofparsefuzz #568

merged 4 commits into from
Feb 17, 2023

Conversation

axic
Copy link
Member

@axic axic commented Feb 17, 2023

Pulled this out from #563. Could be merged on its own.

@axic axic marked this pull request as ready for review February 17, 2023 10:28
@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #568 (fea6399) into master (95a34db) will decrease coverage by 0.44%.
The diff coverage is 36.58%.

❗ Current head fea6399 differs from pull request most recent head 5da8d2f. Consider uploading reports for the commit 5da8d2f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #568      +/-   ##
==========================================
- Coverage   97.41%   96.97%   -0.44%     
==========================================
  Files          67       67              
  Lines        6183     6224      +41     
==========================================
+ Hits         6023     6036      +13     
- Misses        160      188      +28     
Flag Coverage Δ
blockchaintests 75.48% <0.00%> (-1.49%) ⬇️
statetests 71.02% <0.00%> (-0.77%) ⬇️
unittests 92.96% <36.58%> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/evmone/eof.cpp 79.85% <25.71%> (-18.23%) ⬇️
test/unittests/eof_validation_test.cpp 100.00% <100.00%> (ø)
lib/evmone/advanced_analysis.hpp 97.05% <0.00%> (-2.95%) ⬇️
lib/evmone/instructions.hpp 99.79% <0.00%> (-0.21%) ⬇️

@axic axic requested review from rodiazet and gumb0 February 17, 2023 11:30
@axic axic mentioned this pull request Feb 17, 2023
test/eofparse/eofparse.cpp Outdated Show resolved Hide resolved
test/eofparse/eofparse.cpp Outdated Show resolved Hide resolved
test/eofparse/eofparse.cpp Outdated Show resolved Hide resolved
test/eofparse/eofparse.cpp Outdated Show resolved Hide resolved
test/eofparse/eofparse.cpp Outdated Show resolved Hide resolved
template <typename BaseIterator>
struct skip_nonalnum_iterator : evmc::filter_iterator<BaseIterator, isalnum>
{
using evmc::filter_iterator<BaseIterator, isalnum>::filter_iterator;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

surprised that such thing is in public evmc API

test/eofparse/eofparse.cpp Outdated Show resolved Hide resolved
test/eofparse/eofparse.cpp Outdated Show resolved Hide resolved
@axic axic merged commit b8c56ff into master Feb 17, 2023
@axic axic deleted the eof-tools branch February 17, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants