host: Make EOF opaque for EXTCODE* instructions #587
Conversation
chfast
force-pushed
the
eof
branch
2 times, most recently
from
cf08fe5 to
8891cbc
Compare
| } | ||
|
|
||
| bytes32 Host::get_code_hash(const address& addr) const noexcept | ||
| { | ||
| // TODO: Cache code hash. It will be needed also to compute the MPT hash. | ||
| const auto* const acc = m_state.find(addr); | ||
| return (acc != nullptr && !acc->is_empty()) ? keccak256(acc->code) : bytes32{}; | ||
| return (acc != nullptr && !acc->is_empty()) ? keccak256(extcode(acc->code)) : bytes32{}; |
There was a problem hiding this comment.
Patching EXTCODEHASH will be a headache for real implementations. The code hash is available directly in the account node. Now you need to additionally load the code to obtain a possibly different hash.
There was a problem hiding this comment.
Now you need to additionally load the code to obtain a possibly different hash.
This was always the case with this approach. Need to figure out if it is an EOF account or not (by loading the account).
There was a problem hiding this comment.
keccak256("ef00") should better be memoized or hard-coded
There was a problem hiding this comment.
I think this is generally fine for now although it conflicts with the TODO comment above.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #587 +/- ##
=======================================
Coverage 98.05% 98.05%
=======================================
Files 116 117 +1
Lines 11455 11487 +32
=======================================
+ Hits 11232 11264 +32
Misses 223 223
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pdobacz
force-pushed
the
eof2-extcode
branch
from
0f1e606 to
1012ec1
Compare
|
Uses tests from ethereum/tests#1353, which contains some changes on top of the currently used tag for testing EOF in CI state-tests. |
No description provided.