test: Declarative state transition test suite #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
force-pushed
the
test_state_transition
branch
from
062693a to
383074a
Compare
chfast
force-pushed
the
test_state_transition
branch
from
383074a to
1087c53
Compare
gumb0
reviewed
Mar 23, 2023
winsvega
reviewed
Mar 25, 2023
winsvega
reviewed
Mar 25, 2023
| { | ||
| static constexpr auto create_address = 0x864bbda5c698ac34b47a9ea3bd4228802cc5ce3b_address; | ||
|
|
||
| pre.get(*tx.to).code = eof1_bytecode(create() + push(1) + OP_SSTORE + OP_STOP, 3); |
There was a problem hiding this comment.
the ongoing discussion is wether to have an individual tool that will verify validity of EOF
cause strictly there are EOF codes that are valid, but represent an invalid evm code sequence. so it can't be tested through state transition
There was a problem hiding this comment.
what are you talking about, what's invalid evm code sequence?
There was a problem hiding this comment.
In eth rnd execution layer testing channel.
chfast
force-pushed
the
test_state_transition
branch
from
1087c53 to
2297703
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #589 +/- ##
==========================================
+ Coverage 97.21% 97.29% +0.07%
==========================================
Files 74 78 +4
Lines 7571 7640 +69
==========================================
+ Hits 7360 7433 +73
+ Misses 211 207 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gumb0
reviewed
Apr 4, 2023
chfast
force-pushed
the
test_state_transition
branch
3 times, most recently
from
f0caaa8 to
4322ecb
Compare
5 tasks
gumb0
reviewed
Apr 11, 2023
gumb0
reviewed
Apr 11, 2023
chfast
force-pushed
the
test_state_transition
branch
2 times, most recently
from
dae0072 to
7d61b6d
Compare
gumb0
reviewed
Apr 12, 2023
gumb0
reviewed
Apr 12, 2023
gumb0
reviewed
Apr 12, 2023
gumb0
reviewed
Apr 12, 2023
chfast
force-pushed
the
test_state_transition
branch
from
7d61b6d to
04fd5d8
Compare
chfast
force-pushed
the
test_state_transition
branch
from
d133961 to
9926f46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit test fixture based on state transition. The fixture is designed in a way the test cases have structure similar to JSON state tests. This should make it easier to export the test cases to JSON format in the future.