Add t8n full version printing #612
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #612 +/- ##
==========================================
- Coverage 97.29% 97.28% -0.02%
==========================================
Files 78 78
Lines 7648 7648
==========================================
- Hits 7441 7440 -1
- Misses 207 208 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
rodiazet
force-pushed
the
evmone-t8n-version
branch
2 times, most recently
from
3967cf0 to
68e8278
Compare
rodiazet
changed the title
GIT_REV to project version
rodiazet
force-pushed
the
evmone-t8n-version
branch
from
68e8278 to
f8f94f5
Compare
| @@ -39,7 +40,7 @@ int main(int argc, const char* argv[]) | |||
|
|
|||
| if (arg == "-v") | |||
| { | |||
| std::cout << "evmone-t8n " PROJECT_VERSION "\n"; | |||
| std::cout << "evmone-t8n " EVMONE_VERSION "\n"; | |||
There was a problem hiding this comment.
PROJECT_VERSION is not defined any longer.
No we print use evmone-t8n 0.10.0-dev+commit.f8f94f51 previously it was evmone-t8n 0.10.0-dev
| @@ -7,7 +7,7 @@ | |||
|
|
|||
| #include "buildinfo.h" | |||
|
|
|||
| const struct buildinfo* @FUNCTION_NAME@() | |||
| const struct buildinfo* @FUNCTION_NAME@(void) | |||
There was a problem hiding this comment.
/evmone/build/test/t8n/evmone_t8n/buildinfo.h:29:49: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
const struct buildinfo* evmone_t8n_get_buildinfo();
^
void
There was a problem hiding this comment.
Yeah but why wasn't this a problem before?
There was a problem hiding this comment.
There was a problem hiding this comment.
Are you sure you need (void) in the function definition?
FYI this is related to C23 where the meaning of declaration of int f() changes from int f(...) to int f(void). But I think they overdone the warning.
There was a problem hiding this comment.
So for clang 16.0.0 I need but for appleclang 14.0.0.14000029I don't need. I can stop using newer compiler and we don't need to change anything.
There was a problem hiding this comment.
but it looks that it's not only my problem ;) https://app.circleci.com/pipelines/github/ethereum/evmone/4335/workflows/d5b6d7cf-9826-45b1-8586-a9366b89a908/jobs/47373
Ci uses clang 15 which enables this warning by default.
There was a problem hiding this comment.
I think i tested definition too, but will check again on CI
There was a problem hiding this comment.
| @@ -7,7 +7,7 @@ | |||
|
|
|||
| #include "buildinfo.h" | |||
|
|
|||
| const struct buildinfo* @FUNCTION_NAME@() | |||
| const struct buildinfo* @FUNCTION_NAME@(void) | |||
There was a problem hiding this comment.
Are you sure you need (void) in the function definition?
FYI this is related to C23 where the meaning of declaration of int f() changes from int f(...) to int f(void). But I think they overdone the warning.
| @@ -26,7 +26,7 @@ struct buildinfo | |||
| const char* build_type; | |||
| }; | |||
|
|
|||
| const struct buildinfo* @FUNCTION_NAME@(); | |||
| const struct buildinfo* @FUNCTION_NAME@(void); | |||
There was a problem hiding this comment.
Put changes to cable in separate commit and possibly add a CHANGELOG entry in the cmake file.
rodiazet
force-pushed
the
evmone-t8n-version
branch
from
3b1bb63 to
2d5e0f5
Compare
cmake/cable/CableBuildInfo.cmake
Outdated
| @@ -9,6 +9,9 @@ | |||
| # | |||
| # CHANGELOG | |||
| # | |||
| # 1.0.1 - 2023-04-19 | |||
| # - Fix building buildinfo source files. | |||
There was a problem hiding this comment.
| # - Fix building buildinfo source files. | |
| # - Fix -Wstrict-prototypes warning in buildinfo source files. |
Same the commit message can be changed.
rodiazet
force-pushed
the
evmone-t8n-version
branch
from
2d5e0f5 to
990ef97
Compare
No description provided.