Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Switch to new codecov uploader #615

Merged
merged 1 commit into from
Apr 13, 2023
Merged

ci: Switch to new codecov uploader #615

merged 1 commit into from
Apr 13, 2023

Conversation

chfast
Copy link
Member

@chfast chfast commented Apr 12, 2023

Migrates to the new codecov uploader (old one is deprecated).
Good news is that we don't need python any more.
Instead we need to download some "binaries" (project is nodejs based).
We do some integration checks, but I'm not sure how good they are.

I also had to add CODECOV_TOKEN to Circle CI. Some docs say it shouldn't be needed for public repos on Circle CI, but upload wasn't working and worked with the token.

@chfast chfast force-pushed the ci_codecov branch 2 times, most recently from 93ced6a to 919f6fe Compare April 12, 2023 21:37
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #615 (db58b31) into master (a621468) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #615      +/-   ##
==========================================
+ Coverage   97.18%   97.21%   +0.03%     
==========================================
  Files          74       74              
  Lines        7557     7575      +18     
==========================================
+ Hits         7344     7364      +20     
+ Misses        213      211       -2     
Flag Coverage Δ
blockchaintests 63.61% <0.00%> (ø)
statetests 62.58% <14.70%> (-0.04%) ⬇️
unittests 94.11% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/state/state.hpp 96.42% <ø> (ø)
test/statetest/statetest.hpp 100.00% <ø> (ø)
test/unittests/tracing_test.cpp 100.00% <ø> (ø)
lib/evmone/baseline.cpp 100.00% <100.00%> (ø)
lib/evmone/tracing.cpp 100.00% <100.00%> (ø)
lib/evmone/tracing.hpp 94.11% <100.00%> (ø)
test/state/rlp.hpp 100.00% <100.00%> (ø)
test/state/state.cpp 96.72% <100.00%> (ø)
test/statetest/statetest_loader.cpp 89.38% <100.00%> (+0.54%) ⬆️
test/statetest/statetest_runner.cpp 100.00% <100.00%> (ø)
... and 3 more

... and 1 file with indirect coverage changes

@chfast chfast requested review from axic, gumb0 and rodiazet April 12, 2023 22:19
circle.yml Outdated Show resolved Hide resolved
@chfast chfast merged commit f1928c6 into master Apr 13, 2023
@chfast chfast deleted the ci_codecov branch April 13, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants