Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Change default state transition test sender #617

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Conversation

chfast
Copy link
Member

@chfast chfast commented Apr 13, 2023

The new address looks a bit nicer.

@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #617 (9cdcb14) into master (8708f24) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #617   +/-   ##
=======================================
  Coverage   97.29%   97.29%           
=======================================
  Files          79       79           
  Lines        7680     7681    +1     
=======================================
+ Hits         7472     7473    +1     
  Misses        208      208           
Flag Coverage Δ
blockchaintests 65.16% <ø> (ø)
statetests 63.11% <ø> (ø)
unittests 94.84% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/unittests/state_transition_create_test.cpp 100.00% <ø> (ø)
test/unittests/state_transition_block_test.cpp 100.00% <100.00%> (ø)

/// Private key: 0xa45355879.
static constexpr auto Sender = 0xe100DeB58f38F7fd62d14E37e2Fe9ce019Aa001e_address;
/// Private key: 0x2b1263d2b.
static constexpr auto Sender = 0xe100713FC15400D1e94096a545879E7c6407001e_address;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason for the change?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see on the top that it looks nicer.

@chfast chfast merged commit 2b7194e into master Apr 25, 2023
@chfast chfast deleted the test_tx_sender branch April 25, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants